[ 
https://issues.apache.org/jira/browse/HAWQ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238510#comment-15238510
 ] 

ASF GitHub Bot commented on HAWQ-666:
-------------------------------------

GitHub user huor opened a pull request:

    https://github.com/apache/incubator-hawq/pull/600

    HAWQ-666. Restore to correct memory context after free query resource in 
ExecutorEnd

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huor/incubator-hawq huor_memcontext

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/600.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #600
    
----
commit c71e20ceee2ee02d4af0b48a4679e0ff8fd7de72
Author: Ruilong Huo <[email protected]>
Date:   2016-04-13T03:12:37Z

    HAWQ-666. Restore to correct memory context after free query resource in 
ExecutorEnd

----


> Restore to correct memory context after free query resource in ExecutorEnd
> --------------------------------------------------------------------------
>
>                 Key: HAWQ-666
>                 URL: https://issues.apache.org/jira/browse/HAWQ-666
>             Project: Apache HAWQ
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-beta-incubating
>            Reporter: Ruilong Huo
>            Assignee: Ruilong Huo
>             Fix For: 2.0.0
>
>
> In ExecutorEnd, we need to restore to correct memory context after free query 
> resource. There are two memory context based on PG_TRY of mppExecutorFinishup:
> 1. If mppExecutorFinishup completes successfully, the correct memory context 
> is estate->es_query_cxt
> 2. If mppExecutorFinishup errors, the correct memory context is ErrorContext
> Current implementation use estate->es_query_cxt for both situation. We need 
> to fix this as it may lead to core dump during memory context cleanup 
> afterwards.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to