[ 
https://issues.apache.org/jira/browse/HAWQ-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328779#comment-15328779
 ] 

ASF GitHub Bot commented on HAWQ-810:
-------------------------------------

Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/707#discussion_r66898792
  
    --- Diff: src/test/feature/testlib/test_lib.cpp ---
    @@ -73,6 +74,11 @@ TEST_F(TestCommonLib, TestSqlUtil) {
       util.execSQLFile("testlib/sql/sample.sql", "testlib/ans/sample.ans");
     }
     
    +TEST_F(TestCommonLib, TestStringFormat) {
    +  auto s1 = hawq::test::stringFormat("welcome %s to apache %s project", 
"you", "HAWQ");
    +  EXPECT_EQ(s1, "welcome you to apache HAWQ project");
    --- End diff --
    
    Here welcome is used as transitive verb. Refer webster: 
http://www.merriam-webster.com/dictionary/welcome


> Add string format for feature test library
> ------------------------------------------
>
>                 Key: HAWQ-810
>                 URL: https://issues.apache.org/jira/browse/HAWQ-810
>             Project: Apache HAWQ
>          Issue Type: New Feature
>          Components: Tests
>            Reporter: hongwu
>            Assignee: hongwu
>
> For example, define a string:
> {noformat}
> std::string s = stringFormat("hello %s %s world", "xunzhang", "wuhong");
> {noformat}
> instead of:
> {noformat}
> std::string s = "hello" + "xunzhang" + "wuhong" + "world";
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to