[
https://issues.apache.org/jira/browse/HAWQ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354406#comment-15354406
]
ASF GitHub Bot commented on HAWQ-876:
-------------------------------------
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/758#discussion_r68876831
--- Diff: src/test/feature/lib/hawq_config.cpp ---
@@ -151,7 +151,7 @@ bool HawqConfig::isMultinodeMode() {
psql.getQueryResult("select hostname from gp_segment_configuration");
std::vector<std::vector<string> > table = result.getRows();
std::unordered_set<string> hostnameMap;
- for (int i = 0; i < table.size(); i++) {
+ for (unsigned int i = 0; i < table.size(); i++) {
--- End diff --
use `size_t` instead
> Add the support for initFile option of gpdiff.pl in hawq googletest framework.
> ------------------------------------------------------------------------------
>
> Key: HAWQ-876
> URL: https://issues.apache.org/jira/browse/HAWQ-876
> Project: Apache HAWQ
> Issue Type: Bug
> Reporter: Paul Guo
> Assignee: Lei Chang
>
> Hawq googletest framework depends on hawq tool gpdiff.pl. The tool provides
> an enhanced diff comparison between sql output file and expected_out file. It
> supports a useful option "-gpd_init <initFile>' which defines some directives
> for comparison. This option is quite useful for some complex sql tests.
> Current hawq googletest work does not use this option. We need to add this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
