[ 
https://issues.apache.org/jira/browse/HAWQ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356358#comment-15356358
 ] 

ASF GitHub Bot commented on HAWQ-878:
-------------------------------------

Github user wengyanqing commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/759#discussion_r69062485
  
    --- Diff: src/test/feature/ao/TestAoSnappy.cpp ---
    @@ -0,0 +1,126 @@
    +#include "gtest/gtest.h"
    +
    +#include "lib/sql_util.h"
    +
    +using std::string;
    +
    +class TestAOSnappy: public ::testing::Test
    +{
    +   public:
    +           const string initFile = "ao/sql/init_file";
    +           TestAOSnappy() { }
    +           ~TestAOSnappy() {}
    +};
    +
    +TEST_F(TestAOSnappy, Create1048576)
    +{
    +   hawq::test::SQLUtility util;
    --- End diff --
    
    need to check whether util can reuse in the class level


> Add googletest cases for the ao snappy compression support.
> -----------------------------------------------------------
>
>                 Key: HAWQ-878
>                 URL: https://issues.apache.org/jira/browse/HAWQ-878
>             Project: Apache HAWQ
>          Issue Type: Task
>            Reporter: Paul Guo
>            Assignee: Lei Chang
>
> I've added ao snappy support in hawq before. Generally I should have 
> integrated feature with test code in one commit, however I'm not familiar 
> with this tradition before, thus I'm opening a new JIRA to integrate the test 
> case this time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to