Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/781
The patch seems to have some improvement spaces.
lib/*.o was generated by feature/Makefile, however feature/lib/Makefile has
a duplicate makefile rule to generate lib/*.o
I think you could move the rules in feature/lib/Makefile to
feature/Makefile. This makes the code neat.
I'd suggest that the lib name could be more hawq or feature_test specific,
i.e. libtest -> libfeature_test or something else?
Just my 2 cents.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
