[
https://issues.apache.org/jira/browse/HAWQ-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370324#comment-15370324
]
ASF GitHub Bot commented on HAWQ-911:
-------------------------------------
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/781
The patch seems to have some improvement spaces.
lib/*.o was generated by feature/Makefile, however feature/lib/Makefile has
a duplicate makefile rule to generate lib/*.o
I think you could move the rules in feature/lib/Makefile to
feature/Makefile. This makes the code neat.
I'd suggest that the lib name could be more hawq or feature_test specific,
i.e. libtest -> libfeature_test or something else?
Just my 2 cents.
> Optimize and refactor makefiles for feature test framework
> ----------------------------------------------------------
>
> Key: HAWQ-911
> URL: https://issues.apache.org/jira/browse/HAWQ-911
> Project: Apache HAWQ
> Issue Type: Improvement
> Components: Build, Tests
> Reporter: hongwu
> Assignee: hongwu
>
> Current make system has below limitations.
> 1. There is a bug in build UDF/lib: we do not need to remove objects during
> make
> 2. Build everything when developers run make no matter whether the objects
> already exist.
> 3. Bundle generating objects with linking to an executor which is
> time-consuming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
