Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/796#discussion_r70901193
  
    --- Diff: src/include/access/fileam.h ---
    @@ -63,6 +63,17 @@ typedef struct ExternalInsertDescData
     
     typedef ExternalInsertDescData *ExternalInsertDesc;
     
    +/*
    + * ExternalSelectDescData is used for storing state related
    + * to selecting data from an external table.
    + */
    +typedef struct ExternalSelectDescData
    --- End diff --
    
    Why do we introduce new struct if we can just use ProjectionInfo?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to