[ 
https://issues.apache.org/jira/browse/HAWQ-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378646#comment-15378646
 ] 

ASF GitHub Bot commented on HAWQ-927:
-------------------------------------

Github user kavinderd commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/796#discussion_r70904822
  
    --- Diff: src/include/access/fileam.h ---
    @@ -63,6 +63,17 @@ typedef struct ExternalInsertDescData
     
     typedef ExternalInsertDescData *ExternalInsertDesc;
     
    +/*
    + * ExternalSelectDescData is used for storing state related
    + * to selecting data from an external table.
    + */
    +typedef struct ExternalSelectDescData
    --- End diff --
    
    That's an option but since we plan on passing other data like the type of 
query, etc to PXF I think it will be more maintainable to have this 
encapsulating struct so that we don't need to keep changing the method 
signatures.
    
    What are your thoughts?


> Send Projection Info Data from HAWQ to PXF
> ------------------------------------------
>
>                 Key: HAWQ-927
>                 URL: https://issues.apache.org/jira/browse/HAWQ-927
>             Project: Apache HAWQ
>          Issue Type: Sub-task
>          Components: External Tables, PXF
>            Reporter: Kavinder Dhaliwal
>            Assignee: Kavinder Dhaliwal
>             Fix For: backlog
>
>
> To achieve column projection at the level of PXF or the underlying readers we 
> need to first send this data as a Header/Param to PXF. Currently, PXF has no 
> knowledge whether a query requires all columns or a subset of columns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to