Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/828#discussion_r72937658
--- Diff: src/test/feature/lib/xml_parser.h ---
@@ -17,10 +17,27 @@ class XmlConfig {
public:
explicit XmlConfig(std::string);
+ // read an XML file into a tree
+ bool open();
+
+ // only free the XML document pointer
+ void closeNotSave();
+
+ // save the updated document to disk and free the XML document pointer
+ void closeAndSave();
+
// parse the configuration file
void parse();
// @param key The key of the configuration item
+ // @param value The updated value
+ // @param save whether save the updated document to disk, if save is
false, open() and closeAndSave() should be called additionally
+ // @ return The value of configuration item
+ bool setString(const std::string &key, const std::string &value, const
bool &save);
--- End diff --
With POD types, there is no case using const reference. For example, here
we should define as `bool setString(const std::string &key, const std::string
&value, bool save);`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
