Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/846#discussion_r74715268
--- Diff: tools/bin/hawqregister ---
@@ -40,119 +38,126 @@ EXECNAME = os.path.split(__file__)[-1]
setup_tool_logging(EXECNAME,getLocalHostname(),getUserName())
-def create_opt_parser(version):
+def option_parser():
parser = OptParser(option_class=OptChecker,
usage='usage: %prog [options] database_name
table_name file_or_dir_path_in_hdfs',
- version=version)
+ version='%prog version $Revision: #1 $')
parser.remove_option('-h')
parser.add_option('-?', '--help', action='help')
- parser.add_option('-h', '--host', help="host of the target DB")
- parser.add_option('-p', '--port', help="port of the target DB",
type='int', default=0)
- parser.add_option('-U', '--user', help="username of the target DB")
- return parser
+ parser.add_option('-h', '--host', help='host of the target DB')
+ parser.add_option('-p', '--port', help='port of the target DB',
type='int', default=0)
+ parser.add_option('-U', '--user', help='username of the target DB')
+ parser.add_option('-d', '--database', default = 'postgres', dest =
'database', help='database name')
--- End diff --
@xunzhang , I think you can put the interface onto JIRA description, e.g.
the parameters description. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
