Github user mithmatt commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/857#discussion_r76187867
--- Diff: contrib/hawq-ambari-plugin/build.properties ---
@@ -0,0 +1,8 @@
+hawq.release.version=2.0.1
+hawq.common.services.version=2.0.0
+pxf.release.version=3.0.1
+pxf.common.services.version=3.0.0
+hawq.repo.prefix=hawq
+hawq.addons.repo.prefix=hawq-add-ons
+repository.version=2.0.1.0
+default.stack=HDP-2.4
--- End diff --
There is no major problem with putting these parameters back in the pom.xml
I find it to be cleaner and better managed as a separate file.
For the commercial release, a different set of build.properties can be
used. It is easier to use a new build.properties file rather than updating the
pom.xml or explicitly specify overrides for each parameter in the mvn command
during the build process.
Do you still want it back in the pom.xml?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
