Github user xunzhang commented on the issue:

    https://github.com/apache/incubator-hawq/pull/904
  
    Auxiliary Info from Pylint:
    
    ```
    wuhong@pivotal-2:~/Desktop/local/bin$ pylint -E hawqregister
    No config file found, using default configuration
    
    wuhong@pivotal-2:~/Desktop/local/bin$ pylint hawqregister
    No config file found, using default configuration
    ************* Module hawqregister
    C: 20, 0: Line too long (110/100) (line-too-long)
    C: 21, 0: Line too long (120/100) (line-too-long)
    C: 55, 0: Line too long (117/100) (line-too-long)
    C: 56, 0: Line too long (112/100) (line-too-long)
    C: 67, 0: Line too long (144/100) (line-too-long)
    C: 74, 0: Line too long (148/100) (line-too-long)
    C: 77, 0: Line too long (173/100) (line-too-long)
    C: 81, 0: Line too long (182/100) (line-too-long)
    C: 84, 0: Line too long (182/100) (line-too-long)
    C: 87, 0: Line too long (120/100) (line-too-long)
    C: 91, 0: Line too long (156/100) (line-too-long)
    C: 95, 0: Line too long (165/100) (line-too-long)
    C: 98, 0: Line too long (165/100) (line-too-long)
    C:104, 0: Line too long (177/100) (line-too-long)
    C:110, 0: Line too long (172/100) (line-too-long)
    C:121, 0: Line too long (147/100) (line-too-long)
    C:122, 0: Line too long (167/100) (line-too-long)
    C:123, 0: Line too long (149/100) (line-too-long)
    C:125, 0: Line too long (128/100) (line-too-long)
    C:126, 0: Line too long (153/100) (line-too-long)
    C:127, 0: Line too long (130/100) (line-too-long)
    C:148, 0: Line too long (106/100) (line-too-long)
    C:151, 0: Line too long (110/100) (line-too-long)
    C:157, 0: Line too long (147/100) (line-too-long)
    C:158, 0: Line too long (182/100) (line-too-long)
    C:160, 0: Line too long (164/100) (line-too-long)
    C:161, 0: Line too long (214/100) (line-too-long)
    C:166, 0: Line too long (167/100) (line-too-long)
    C:178, 0: Line too long (109/100) (line-too-long)
    C:179, 0: Line too long (145/100) (line-too-long)
    C:203, 0: Line too long (152/100) (line-too-long)
    C:204, 0: Line too long (127/100) (line-too-long)
    C:205, 0: Line too long (157/100) (line-too-long)
    C:206, 0: Line too long (139/100) (line-too-long)
    C:208, 0: Line too long (129/100) (line-too-long)
    C:252, 0: Line too long (117/100) (line-too-long)
    C:256, 0: Line too long (162/100) (line-too-long)
    C:259, 0: Line too long (102/100) (line-too-long)
    C:265, 0: Line too long (162/100) (line-too-long)
    C:289, 0: Line too long (107/100) (line-too-long)
    C:297, 0: Line too long (164/100) (line-too-long)
    C:300, 0: Line too long (105/100) (line-too-long)
    C:329, 0: Line too long (136/100) (line-too-long)
    C:339, 0: Line too long (117/100) (line-too-long)
    C:341, 0: Line too long (179/100) (line-too-long)
    C:345, 0: Line too long (116/100) (line-too-long)
    C:401, 0: Line too long (125/100) (line-too-long)
    C:405, 0: Line too long (133/100) (line-too-long)
    C:415, 0: Line too long (117/100) (line-too-long)
    C:422, 0: Line too long (125/100) (line-too-long)
    C:426, 0: Line too long (133/100) (line-too-long)
    C:433, 0: Line too long (117/100) (line-too-long)
    C:460, 0: Line too long (103/100) (line-too-long)
    C:469, 0: Line too long (101/100) (line-too-long)
    C:  1, 0: Missing module docstring (missing-docstring)
    C: 32,20: Invalid variable name "e" (invalid-name)
    C: 38, 0: Invalid constant name "logger" (invalid-name)
    W: 45, 4: Redefining name 'parser' from outer scope (line 478) 
(redefined-outer-name)
    C: 62, 0: Invalid argument name "D" (invalid-name)
    C: 79,12: Invalid variable name "d" (invalid-name)
    C: 93, 8: Invalid variable name "d" (invalid-name)
    R: 62, 0: Too many branches (20/12) (too-many-branches)
    C:114, 0: Missing function docstring (missing-docstring)
    C:116,32: Invalid variable name "f" (invalid-name)
    C:130, 0: Missing class docstring (missing-docstring)
    C:147, 4: Missing method docstring (missing-docstring)
    C:151, 4: Missing method docstring (missing-docstring)
    R:151, 4: Too many arguments (7/5) (too-many-arguments)
    C:165, 4: Missing method docstring (missing-docstring)
    C:176, 4: Missing method docstring (missing-docstring)
    C:191, 4: Missing method docstring (missing-docstring)
    C:199, 4: Missing method docstring (missing-docstring)
    C:207, 8: Invalid variable name "D" (invalid-name)
    C:211, 4: Missing method docstring (missing-docstring)
    C:215, 0: Missing class docstring (missing-docstring)
    R:215, 0: Too many instance attributes (21/7) (too-many-instance-attributes)
    W:216,23: Redefining name 'options' from outer scope (line 479) 
(redefined-outer-name)
    C:228, 8: Missing function docstring (missing-docstring)
    C:245, 8: Missing function docstring (missing-docstring)
    C:249, 8: Missing function docstring (missing-docstring)
    C:255, 8: Missing function docstring (missing-docstring)
    C:258, 8: Missing function docstring (missing-docstring)
    C:261, 8: Missing function docstring (missing-docstring)
    C:304,23: Invalid variable name "f" (invalid-name)
    R:244, 4: Too many branches (20/12) (too-many-branches)
    R:244, 4: Too many statements (51/50) (too-many-statements)
    C:328, 4: Invalid method name "_check_files_and_table_in_same_hdfs_cluster" 
(invalid-name)
    R:328, 4: Method could be a function (no-self-use)
    W:353,21: Unused variable 'err' (unused-variable)
    R:344, 4: Method could be a function (no-self-use)
    C:368,12: Invalid variable name "f" (invalid-name)
    C:370,12: Invalid variable name "rc" (invalid-name)
    W:370,21: Unused variable 'err' (unused-variable)
    W:370,12: Unused variable 'rc' (unused-variable)
    R:366, 4: Method could be a function (no-self-use)
    C:384,12: Invalid variable name "f" (invalid-name)
    R:396, 4: Too many branches (13/12) (too-many-branches)
    C:437, 4: Missing method docstring (missing-docstring)
    R:215, 0: Too few public methods (1/2) (too-few-public-methods)
    W:450,18: Redefining name 'args' from outer scope (line 479) 
(redefined-outer-name)
    W:450, 9: Redefining name 'options' from outer scope (line 479) 
(redefined-outer-name)
    C:450, 0: Missing function docstring (missing-docstring)
    W:451,18: Redefining name 'options' from outer scope (line 479) 
(redefined-outer-name)
    C:478, 4: Invalid constant name "parser" (invalid-name)
    C:479, 4: Invalid constant name "options" (invalid-name)
    C:479,13: Invalid constant name "args" (invalid-name)
    
    
    Report
    ======
    366 statements analysed.
    
    Statistics by type
    ------------------
    
    +---------+-------+-----------+-----------+------------+---------+
    |type     |number |old number |difference |%documented |%badname |
    +=========+=======+===========+===========+============+=========+
    |module   |1      |1          |=          |0.00        |0.00     |
    +---------+-------+-----------+-----------+------------+---------+
    |class    |2      |2          |=          |0.00        |0.00     |
    +---------+-------+-----------+-----------+------------+---------+
    |method   |18     |18         |=          |55.56       |5.56     |
    +---------+-------+-----------+-----------+------------+---------+
    |function |11     |11         |=          |27.27       |0.00     |
    +---------+-------+-----------+-----------+------------+---------+
    
    
    
    External dependencies
    ---------------------
    ::
    
        yaml (hawqregister)
    
    
    
    Raw metrics
    -----------
    
    +----------+-------+------+---------+-----------+
    |type      |number |%     |previous |difference |
    +==========+=======+======+=========+===========+
    |code      |391    |79.63 |391      |=          |
    +----------+-------+------+---------+-----------+
    |docstring |15     |3.05  |15       |=          |
    +----------+-------+------+---------+-----------+
    |comment   |36     |7.33  |36       |=          |
    +----------+-------+------+---------+-----------+
    |empty     |49     |9.98  |49       |=          |
    +----------+-------+------+---------+-----------+
    
    
    
    Duplication
    -----------
    
    +-------------------------+------+---------+-----------+
    |                         |now   |previous |difference |
    +=========================+======+=========+===========+
    |nb duplicated lines      |0     |0        |=          |
    +-------------------------+------+---------+-----------+
    |percent duplicated lines |0.000 |0.000    |=          |
    +-------------------------+------+---------+-----------+
    
    
    
    Messages by category
    --------------------
    
    +-----------+-------+---------+-----------+
    |type       |number |previous |difference |
    +===========+=======+=========+===========+
    |convention |88     |88       |=          |
    +-----------+-------+---------+-----------+
    |refactor   |10     |10       |=          |
    +-----------+-------+---------+-----------+
    |warning    |8      |8        |=          |
    +-----------+-------+---------+-----------+
    |error      |0      |0        |=          |
    +-----------+-------+---------+-----------+
    
    
    
    Messages
    --------
    
    +-----------------------------+------------+
    |message id                   |occurrences |
    +=============================+============+
    |line-too-long                |54          |
    +-----------------------------+------------+
    |missing-docstring            |19          |
    +-----------------------------+------------+
    |invalid-name                 |15          |
    +-----------------------------+------------+
    |redefined-outer-name         |5           |
    +-----------------------------+------------+
    |unused-variable              |3           |
    +-----------------------------+------------+
    |too-many-branches            |3           |
    +-----------------------------+------------+
    |no-self-use                  |3           |
    +-----------------------------+------------+
    |too-many-statements          |1           |
    +-----------------------------+------------+
    |too-many-instance-attributes |1           |
    +-----------------------------+------------+
    |too-many-arguments           |1           |
    +-----------------------------+------------+
    |too-few-public-methods       |1           |
    +-----------------------------+------------+
    
    
    
    Global evaluation
    -----------------
    Your code has been rated at 7.10/10 (previous run: 7.10/10, +0.00)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to