Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/906#discussion_r79488894
  
    --- Diff: 
pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/HiveORCSearchArgumentExample.java
 ---
    @@ -0,0 +1,84 @@
    +package org.apache.hawq.pxf.plugins.hive;
    +
    +import org.apache.hadoop.hive.ql.io.sarg.SearchArgument;
    +import org.apache.hadoop.hive.ql.io.sarg.SearchArgumentFactory;
    +import org.apache.hawq.pxf.api.BasicFilter;
    +import org.apache.hawq.pxf.api.LogicalFilter;
    +import org.apache.hawq.pxf.api.utilities.ColumnDescriptor;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.util.Arrays;
    +import java.util.List;
    +
    +public class HiveORCSearchArgumentExample {
    --- End diff --
    
    Rename this class as HiveORCSearchArgumentTest. All of the test classes end 
with name ***Test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to