Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/906#discussion_r79486684
  
    --- Diff: 
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java ---
    @@ -220,6 +193,24 @@ public Object parse(String filter) throws Exception {
                         // Store result on stack
                         operandsStack.push(result);
                         break;
    +                case 'l':
    +                    LogicalOperation logicalOperation = 
logicalOperationTranslationMap.get(safeToInt(parseNumber()));
    +
    +                    if (logicalOperation == null) {
    +                        throw new FilterStringSyntaxException("unknown op 
ending at " + index);
    +                    }
    +
    +                    if (logicalOperation == LogicalOperation.HDOP_NOT) {
    +                        Object exp = operandsStack.pop();
    +                        result = filterBuilder.build(logicalOperation, 
exp);
    +                    } else {
    --- End diff --
    
    might be good to explicitly check for enum values here just in case we add 
support for more logical operations. If not atleast add a comment here about 
the logical operations being handled in this case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to