Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/906#discussion_r79487522
  
    --- Diff: 
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java ---
    @@ -81,6 +88,8 @@
              * @throws Exception if building the filter failed
              */
             public Object build(Operation operation, Object left, Object 
right) throws Exception;
    +        public Object build(LogicalOperation operation, Object left, 
Object right) throws Exception;
    --- End diff --
    
    Since these are functions in an interface, each function needs to have a 
well defnined javadoc comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to