Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/915#discussion_r79740591
  
    --- Diff: src/backend/access/external/pxfheaders.c ---
    @@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input)
        if (proj_info != NULL && proj_info->pi_isVarList)
        {
                List* qualsAttributes = extractPxfAttributes(input->quals);
    -
    -           add_projection_desc_httpheader(headers, proj_info, 
qualsAttributes);
    +           /* projection information is incomplete if columns from WHERE 
clause wasn't extracted */
    +           if (qualsAttributes !=  NIL || list_length(input->quals) == 0)
    --- End diff --
    
    extractPxfAttributes function might return NIL in two cases - when input 
quals are empty or some error occurred during extraction. So this condition 
list_length(input->quals) == 0 means no input quals has been passed thus 
nothing was extracted and it's safe to add projection info.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to