Github user paul-guo- commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/921#discussion_r79763445
  
    --- Diff: tools/bin/lib/.gitignore ---
    @@ -2,7 +2,3 @@ netperf
     netserver
     stream
     Crypto
    --- End diff --
    
    +1. Good catch for the whole issue.
    
    By the way, tools/Makefile seems to be buggy. See the following patch.
    This misleads me also. @ edespino and @radarwave ,
    how about the patch below? If yes, Ed you probably could
    add this change in you patch?
    
    diff --git a/tools/Makefile b/tools/Makefile
    index 172f6f6..3eb49f6 100644
    --- a/tools/Makefile
    +++ b/tools/Makefile
    @@ -27,6 +27,7 @@ include $(top_builddir)/src/Makefile.global
    
     all:
        ${MAKE} -C gpnetbench $@
    +   ${MAKE} -C bin $@
    
     install :
        ${MAKE} -C bin $@



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to