Github user stanlyxiang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/928#discussion_r80054816
  
    --- Diff: src/backend/resourcemanager/requesthandler.c ---
    @@ -627,7 +627,11 @@ bool handleRMSEGRequestIMAlive(void **arg)
        fts_client_ip_len = strlen(fts_client_ip);
        inet_aton(fts_client_ip, &fts_client_addr);
        fts_client_host = gethostbyaddr(&fts_client_addr, 4, AF_INET);
    -   Assert(fts_client_host != NULL);
    +   if (fts_client_host == NULL)
    +   {
    +           elog(WARNING, "Failed to reverse DNS lookup for ip %s.", 
fts_client_ip);
    +           return true;
    +   }
     
    --- End diff --
    
    Not quit after "reverse dns lookup" failure. This function handles the 
IMAlive message from segment resource manager process.  "return true" just 
ignore this message and do not continue the followup work after a lookup 
failure.  IP address is not enough since followup work needs the hostname.
    
    For replace gethostbyaddr(), @jiny2 could you give some comments ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to