Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/913#discussion_r80160834
  
    --- Diff: src/backend/access/external/pxffilters.c ---
    @@ -187,38 +208,19 @@ pxf_make_filter_list(List *quals)
                {
                        case T_OpExpr:
                        {
    -                           OpExpr                  *expr   = (OpExpr *) 
node;
    -                           PxfFilterDesc   *filter;
    -
    -                           filter = (PxfFilterDesc *) 
palloc0(sizeof(PxfFilterDesc));
    -                           elog(DEBUG5, "pxf_make_filter_list: node tag %d 
(T_OpExpr)", tag);
    -
    -                           if (opexpr_to_pxffilter(expr, filter))
    -                                   result = lappend(result, filter);
    -                           else
    -                                   pfree(filter);
    -
    +                           result = lappend(result, node);
                                break;
                        }
                        case T_BoolExpr:
                        {
                                BoolExpr        *expr = (BoolExpr *) node;
    -                           BoolExprType boolType = expr->boolop;
    -                           elog(DEBUG5, "pxf_make_filter_list: node tag %d 
(T_BoolExpr), bool node type %d %s",
    -                                           tag, boolType, 
boolType==AND_EXPR ? "(AND_EXPR)" : "");
    -
    -                           /* only AND_EXPR is supported */
    -                           if (expr->boolop == AND_EXPR)
    -                           {
    -                                   List *inner_result = 
pxf_make_filter_list(expr->args);
    -                                   elog(DEBUG5, "pxf_make_filter_list: 
inner result size %d", list_length(inner_result));
    -                                   result = list_concat(result, 
inner_result);
    -                           }
    +                           List *inner_result = 
pxf_make_expression_items_list(expr->args);
    +                           result = list_concat(result, inner_result);
    +                           result = lappend(result, node);
                                break;
                        }
                        default:
    -                           /* expression not supported. ignore */
    -                           elog(DEBUG5, "pxf_make_filter_list: unsupported 
node tag %d", tag);
    +                           elog(DEBUG5, "pxf_make_expression_items_list: 
unsupported node tag %d", tag);
    --- End diff --
    
    lets make this DEBUG1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to