Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/929#discussion_r80166350
  
    --- Diff: tools/bin/hawqregister ---
    @@ -469,8 +481,8 @@ class HawqRegister(object):
                 self.filepath = self.files[0][:self.files[0].rfind('/')] if 
self.files else ''
                 check_file_not_folder()
                 check_database_encoding()
    -            if self.mode != 'force' and self.mode != 'repair':
    -                if not create_table():
    +            if self.mode != 'repair':
    +                if not create_table() and self.mode != 'force':
    --- End diff --
    
    A little confused here, I think handle the edge case in _init_mode() could 
be much more clear. In detail, in this case set 
self.mode='usage2_table_non_exist' instead of 'force'. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to