Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/906#discussion_r83091487
  
    --- Diff: 
pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java
 ---
    @@ -71,14 +74,19 @@ public HBaseFilterBuilder(HBaseTupleDescription 
tupleDescription) {
          * @throws Exception if parsing failed
          */
         public Filter getFilterObject(String filterString) throws Exception {
    -        FilterParser parser = new FilterParser(this);
    -        Object result = parser.parse(filterString);
    +        // First check for NOT, HBase does not support this
    +        if (filterString.contains(NOT_OP)) {
    +            return null;
    +        } else {
    +            FilterParser parser = new FilterParser(this);
    +            Object result = parser.parse(filterString);
    +
    +            if (!(result instanceof Filter)) {
    +                throw new Exception("String " + filterString + " resolved 
to no filter");
    --- End diff --
    
    Rewrite error message to something like "String couldn't be resolved to any 
supported filter"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to