Github user kavinderd commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/958#discussion_r83111789
  
    --- Diff: src/backend/access/external/pxffilters.c ---
    @@ -31,14 +31,14 @@
     #include "utils/guc.h"
     #include "utils/lsyscache.h"
     
    -static List* pxf_make_filter_list(List* quals);
    +static List* pxf_make_expression_items_list(List *quals, Node *parent, 
bool *logicalOpsNum);
     static void pxf_free_filter(PxfFilterDesc* filter);
    -static void pxf_free_filter_list(List *filters);
     static char* pxf_serialize_filter_list(List *filters);
     static bool opexpr_to_pxffilter(OpExpr *expr, PxfFilterDesc *filter);
     static bool supported_filter_type(Oid type);
     static void const_to_str(Const *constval, StringInfo buf);
     static List* append_attr_from_var(Var* var, List* attrs);
    +static void enrichTrivialExpression(List *expressionItems);
    --- End diff --
    
    change function signature to match style with underscores 
`enrich_trivial_expression`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to