Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/965#discussion_r83957988
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveORCAccessor.java
---
@@ -131,15 +139,20 @@ private void buildExpression(SearchArgument.Builder
builder, List<Object> filter
builder.startNot();
break;
}
- buildExpression(builder, ((LogicalFilter)
f).getFilterList());
- builder.end();
+ if (buildExpression(builder, ((LogicalFilter)
f).getFilterList()))
+ builder.end();
+ else
+ return false;
} else {
- buildArgument(builder, f);
+ if (!buildArgument(builder, f))
--- End diff --
We need to return false only if buildArgument(builder, f) call returned
false, in case of true we want to proceed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
