[
https://issues.apache.org/jira/browse/HAWQ-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643458#comment-15643458
]
Ming LI commented on HAWQ-968:
------------------------------
Hi Hong,
Could you share with me more info? I went thought the code in url_fclose(),
although there are many code entry for calling "free(file); ", but they are all
just one-time free. Thanks.
Specially FYI. below code snippet only call free(file) when report error, after
that it will longjmp to other place. So it only just call one-time.
{code}
if (failOnError) free(file);
ereport( (failOnError ? ERROR : LOG) ....
{code}
> Incorrect free in url_fclose
> ----------------------------
>
> Key: HAWQ-968
> URL: https://issues.apache.org/jira/browse/HAWQ-968
> Project: Apache HAWQ
> Issue Type: Bug
> Components: External Tables
> Affects Versions: backlog
> Reporter: hongwu
> Assignee: hongwu
> Priority: Minor
> Fix For: backlog
>
>
> There is potential double free risk in
> url_fclose(https://github.com/apache/incubator-hawq/blob/master/src/backend/access/external/url.c#L1161)
> of url.c.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
