Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1007#discussion_r87318413
--- Diff: src/test/feature/gtest-parallel ---
@@ -234,6 +234,71 @@ class TestTimes(object):
except IOError:
pass # ignore errors---saving the times isn't that important
+
+def get_schedule(schedule_file):
+ "read schedule file from --gtest_schedule option"
+ try:
+ file = open(schedule_file, 'r')
+ except (EOFError, IOError):
+ sys.exit("Read file error")
+
+ filter_test = []
+ ptest = []
+ stest = []
+
+ for line in file.readlines():
--- End diff --
Actually I do not like the for-loop her because I think it is a little
tricky. If you need a key-value dict information, could we change the file with
json format?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
