Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/981#discussion_r89230552
--- Diff: src/backend/access/external/pxffilters.c ---
@@ -719,6 +1029,143 @@ const_to_str(Const *constval, StringInfo buf)
/*
+ * list_const_to_str
+ *
+ */
+static void
+list_const_to_str(Const *constval, StringInfo buf)
+{
+ StringInfo interm_buf;
+ Datum *dats;
+ ArrayType *arr;
+ int len;
+
+ if (constval->constisnull)
+ {
+ elog(DEBUG1, "Null constant is not expected in this context.");
+ return;
+ }
+
+ if (constval->constbyval) {
--- End diff --
This check seems a bit unnecessary as we would never get this expression
down to our code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
