Github user paul-guo- commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1032#discussion_r90579306
  
    --- Diff: src/backend/catalog/pg_filesystem.c ---
    @@ -384,7 +384,7 @@ FileSystemGetNameByOid(Oid      fsysOid)
     
     char *fsys_func_type_to_name(FileSystemFuncType ftype)
     {
    -   if(ftype < 0 || ftype >= FSYS_FUNC_TOTALNUM)
    +   if (!(ftype >= FSYS_FUNC_CONNECT && ftype < FSYS_FUNC_TOTALNUM))
    --- End diff --
    
    It does not seem to need a conversion of !. 
    The code below seems to apply either unsigned or signed type, which enum 
may use.
    ftype < FSYS_FUNC_CONNECT || ftype >= FSYS_FUNC_TOTALNUM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to