Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1047#discussion_r92317398
--- Diff: src/backend/parser/parse_relation.c ---
@@ -2713,15 +2712,90 @@ warnAutoRange(ParseState *pstate, RangeVar
*relation, int location)
void
ExecCheckRTPerms(List *rangeTable)
{
+ if (enable_ranger)
+ {
+ if(rangeTable!=NULL)
+ ExecCheckRTPermsWithRanger(rangeTable);
+ return;
+ }
ListCell *l;
-
foreach(l, rangeTable)
{
ExecCheckRTEPerms((RangeTblEntry *) lfirst(l));
}
}
/*
+ * ExecCheckRTPerms
+ * Batch implementation: Check access permissions for all relations
listed in a range table with enable_ranger is true.
+ */
+void
+ExecCheckRTPermsWithRanger(List *rangeTable)
+{
+ List *ranger_check_args = NIL;
+ ListCell *l;
+ foreach(l, rangeTable)
+ {
+
+ AclMode requiredPerms;
+ Oid relOid;
+ Oid userid;
+ RangeTblEntry *rte = (RangeTblEntry *) lfirst(l);
+
+ if (rte->rtekind != RTE_RELATION)
+ return;
+ requiredPerms = rte->requiredPerms;
+ if (requiredPerms == 0)
+ return;
+
+ relOid = rte->relid;
+ userid = rte->checkAsUser ? rte->checkAsUser : GetUserId();
+
+ RangerPrivilegeArgs *ranger_check_arg = (RangerPrivilegeArgs *)
palloc(sizeof(RangerPrivilegeArgs));
+ ranger_check_arg->objkind = ACL_KIND_CLASS;
+ ranger_check_arg->object_oid = relOid;
+ ranger_check_arg->roleid = userid;
+ ranger_check_arg->mask = requiredPerms;
+ ranger_check_arg->how = ACLMASK_ALL;
+ ranger_check_args = lappend(ranger_check_args, ranger_check_arg);
+
+ } // foreach
+
+ // ranger ACL check with package Oids
+ List *aclresults = NIL;
+ aclresults = pg_rangercheck_batch(ranger_check_args);
+ if (aclresults == NIL)
+ {
+ elog(ERROR, "ERROR\n");
--- End diff --
yes, this error message should be replaced by the exact error message in
future. for example, which table doesn't pass the acl check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
