Github user wcl14 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1050#discussion_r92545931
--- Diff: tools/bin/hawqregister ---
@@ -1145,7 +1153,7 @@ def main(options, args):
failure_handler = FailureHandler(conn)
# register
- if options.yml_config and ispartition(options.yml_config):
+ if check_file_exist(options.yml_config) and
ispartition(options.yml_config):
--- End diff --
I just think check_file_exist() should not be called in the if statement.
In this statement, it may be confused the condition for whether is partition or
not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
