Github user paul-guo- commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1073#discussion_r94379663
  
    --- Diff: contrib/hawq-docker/Makefile ---
    @@ -0,0 +1,205 @@
    +#!/usr/bin/make all
    +
    +THIS_MAKEFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))
    +TOP_DIR := $(abspath $(dir ${THIS_MAKEFILE_PATH}))
    +NDATANODES := 3
    +CUR_DATANODE := 1
    +OS_VERSION := centos7
    +# Do not use underscore "_" in CLUSTER_ID
    +CLUSTER_ID := $(OS_VERSION)
    +# Monut this local directory to /data in data container and share with 
other containers
    +LOCAL := 
    --- End diff --
    
    This comment seems to be a bit confusing. I guess /data is in containers, 
right. I guess there could be a better name other than LOCAL? e.g. 
ROOT_DATA_PATH? SHARE_DATA_PATH? PIVOT_DATA_PATH? or other name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to