Github user linwen commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1079#discussion_r95521589
  
    --- Diff: src/backend/tcop/postgres.c ---
    @@ -133,6 +135,7 @@ extern char *optarg;
     extern char *savedSeqServerHost;
     extern int savedSeqServerPort;
     
    +struct curl_context_t curl_context;
    --- End diff --
    
    The name of this global variable "curl_context", seems ambiguous, code 
readers can't know what is this curl context used for. maybe "curl_context_rps" 
or "curl_context_ranger" is better, indicates this curl context is used for 
Ranger Plugin Service. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to