Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1081#discussion_r95528917
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -68,51 +69,99 @@ static void getClientIP(char *remote_host)
}
}
-RangerACLResult parse_ranger_response(char* buffer)
+/*
+ * parse ranger response
+ * @param buffer ranger response
+ * @param result_list List of RangerPrivilegeResults
+ * @return 0 parse success; -1 other error
+ */
+static int parse_ranger_response(char* buffer, List *result_list)
{
if (buffer == NULL || strlen(buffer) == 0)
- return RANGERCHECK_UNKNOWN;
+ return -1;
--- End diff --
I don't think -1 is more readable than "RANGERCHECK_UNKNOWN".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
