Github user stanlyxiang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1088#discussion_r96179729
  
    --- Diff: src/backend/libpq/rangerrest.c ---
    @@ -366,7 +365,7 @@ static size_t write_callback(char *contents, size_t 
size, size_t nitems,
        if (curl->response.buffer == NULL)
        {
                /* out of memory! */
    -           elog(WARNING, "not enough memory for Ranger response");
    +           elog(WARNING, "cannot allocate memory for ranger response");
    --- End diff --
    
    hmm, IMO , not enough memory is not the only error that will occur. There 
maybe other errors  in the repalloc implementation. So I changed the messages.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to