Github user kavinderd commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1102#discussion_r98055597
  
    --- Diff: pxf/pxf-service/src/scripts/pxf-service ---
    @@ -40,6 +34,29 @@ else
        source $env_script
     fi
     
    +pxf_user=$PXF_USER
    +instance_port=$PXF_PORT
    +instance_name=pxf-service
    +
    +if [ -z $PXF_HOME ]; then
    +    # RPM based setup
    +    pxf_root=/usr/lib/pxf
    +    tomcat_root=/opt/apache-tomcat
    +    tomcat_templates=/opt/pxf/tomcat-templates
    +    instance_root=/var/pxf
    +    instance_owner=$pxf_user:$pxf_user
    +else
    +    # OSS/Source code based setup
    +    pxf_root=$PXF_HOME/lib
    +    tomcat_root=$PXF_HOME/apache-tomcat
    +    tomcat_templates=$PXF_HOME/tomcat-templates
    +    instance_root=$PXF_HOME
    +    instance_owner=$pxf_user
    +fi
    +
    +curl=`which curl`
    --- End diff --
    
    Maybe check that this command returns a non-null value


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to