Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1076#discussion_r98127047
--- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java
---
@@ -91,12 +94,17 @@ public Field(String name, EnumHawqType type, String
sourceType) {
this.sourceType = sourceType;
}
- public Field(String name, EnumHawqType type, String sourceType,
- String[] modifiers) {
+ public Field(String name, EnumHawqType type, String sourceType,
String[] modifiers) {
this(name, type, sourceType);
this.modifiers = modifiers;
}
+ public Field(String name, EnumHawqType type, boolean
isComplexType, String sourceType, String[] modifiers) {
--- End diff --
Add isComplexType as the final argument to keep the method overloading
structure clean
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
