Github user stanlyxiang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1143#discussion_r102678227
  
    --- Diff: config/tomcat.m4 ---
    @@ -0,0 +1,59 @@
    +dnl
    +dnl tomcat.m4: Locates the Apache Tomcat/6.0.x and its scripts and jars. 
    +dnl
    +
    +# PGAC_CATALINA_HOME
    +# ------------------
    +AC_DEFUN([PGAC_CATALINA_HOME],
    +[
    +  AC_MSG_CHECKING([CATALINA_HOME])
    +
    +  dnl Use $CATALINA_HOME if specifed, otherwise look for java in the 
likely places.
    +  dnl /usr/local/Cellar/tomcat@6/6.0.45/libexec 
    +  dnl /usr/lib/bigtop-tomcat
    +  if test -x "${CATALINA_HOME}/bin/catalina.sh"; then
    +    TOMCAT="${CATALINA_HOME}"
    +  elif test -x 
"/usr/local/Cellar/tomcat@6/6.0.45/libexec/bin/catalina.sh"; then
    --- End diff --
    
    Oh. No, the version should be 6.0.x. I will remove this else option since I 
just found it's too specific to the path. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to