Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1163#discussion_r104688429
--- Diff: src/backend/gp_libpq_fe/fe-protocol3.c ---
@@ -2296,20 +2261,8 @@ build_startup_packet(const PGconn *conn, char
*packet,
if ((val = getenv(next_eo->envName)) != NULL)
{
if (pg_strcasecmp(val, "default") != 0)
- {
- if (packet)
- strcpy(packet + packet_len,
next_eo->pgName);
- packet_len += strlen(next_eo->pgName) + 1;
- if (packet)
- strcpy(packet + packet_len, val);
- packet_len += strlen(val) + 1;
- }
- } if (packet)
- strcpy(packet + packet_len, "options");
- packet_len += strlen("options") + 1;
- if (packet)
- strcpy(packet + packet_len, conn->pgoptions);
- packet_len += strlen(conn->pgoptions) + 1;
+ ADD_STARTUP_OPTION(next_eo->pgName, val);
+ }
--- End diff --
There were two pieces for the same code in original code, in the PR it only
has 1. Will there be a problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
