Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1164#discussion_r104744742
  
    --- Diff: ranger-plugin/conf/rps.properties ---
    @@ -29,4 +29,7 @@ RPS_SHUTDOWN_PORT=8405
     RANGER_HAWQ_INSTANCE=hawq
     
     # version of the software
    -RPS_VERSION=${project.version}
    \ No newline at end of file
    +RPS_VERSION=${project.version}
    +
    +# home path of Tomcat/6.0.x for Ranger Plugin Service
    +CATALINA_HOME=
    --- End diff --
    
    should this line not be here by default and only be added by users 
configuring the system from the build script ? Users that install from RPM do 
not need this property and might be confused why it is empty in this file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to