Github user liming01 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1187#discussion_r108081777
--- Diff: src/backend/access/appendonly/appendonlywriter.c ---
@@ -923,30 +923,34 @@ usedByConcurrentTransaction(AOSegfileStatus
*segfilestat)
*/
int
addCandidateSegno(AOSegfileStatus **maxSegno4Seg, int segment_num,
AOSegfileStatus *candidate_status, bool isKeepHash)
--- End diff --
Because github default ts=8, which may a lot indentation looks strange.
However our code convention is to set ts=4.
e.g. When you review code, please append '?ts=4' to web URL as below:
https://github.com/apache/incubator-hawq/pull/1187/files?ts=4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
