Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1208#discussion_r109062506
  
    --- Diff: pxf/build.gradle ---
    @@ -41,17 +41,22 @@ buildscript {
         }   
     }
     
    -// Hadoop distribution (can be phd or hdp) - needed to set correct 
classpaths
    +// Hadoop distribution (can be hdp or null which would default to apache) 
- needed to set correct classpaths
     // can be set with -Dhd=<value>
    -def hddist = System.properties['hd'] ?: 'hdp';
    -if (hddist != 'phd' && hddist != 'hdp') {
    +def hddist = System.properties['hd'] ?: '';
    --- End diff --
    
    As long as we don't have default value, shouldn't it be just: def hddist = 
System.properties['hd']?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to