Github user kavinderd commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1216#discussion_r111190746
  
    --- Diff: 
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/Utilities.java ---
    @@ -209,7 +209,8 @@ public static boolean useAggBridge(InputData inputData) 
{
                 LOG.error("Unable to load accessor class: " + e.getMessage());
                 return false;
             }
    -        return (inputData != null) && (inputData.getAggType() != null)
    +        return (inputData != null) && !inputData.hasFilter()
    --- End diff --
    
    Maybe add a comment for why so many checks are required


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to