Github user hsyuan commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1230#discussion_r114932353
  
    --- Diff: src/backend/commands/analyze.c ---
    @@ -308,7 +308,7 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int 
preferred_seg_num)
        ListCell                                *le1 = NULL;
        int                                     successCount = 0, failCount = 0;
        StringInfoData                  failNames;
    -   ResourceOwner owner, oldOwner;
    +   ResourceOwner asOwner, oldOwner1;
    --- End diff --
    
    if `as` of `asOwner` means `analyzeStmt`,  we'd better add comments or 
explanation on the both vars. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to