Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1225#discussion_r118807905
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/BridgeOutputBuilder.java
---
@@ -137,6 +137,18 @@ public Writable getErrorOutput(Exception ex) throws
Exception {
return outputList;
}
+ public LinkedList<Writable> makeVectorizedOutput(List<List<OneField>>
recordsBatch) throws BadRecordException {
+ outputList.clear();
+ for (List<OneField> record : recordsBatch) {
--- End diff --
no null checks necessary for recordsBatch and record ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
