Github user outofmem0ry commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1254
  
    @linwen @stanlyxiang @radarwave - Thank you for the comments and 
suggestions.
    
    @radarwave - Please see the comments inline
    
    1. I think we should keep the legacy command to do reload in case it's hard 
coded in some user cases, print a deprecated message should be fine.
    
    > The change that is committed prints a message as seen below and exits. I 
can change the message and let the command continue.
    
    ```
    hawq stop cluster -u
    To reload GUC values without restarting hawq cluster use 'hawq 
reload-config <object>'
    ```
    2. Make sure all the related help messages and documents are updated.
    
    > This is something that will go into incubator-hawq-docs and am working on 
scoping the change for this.
    3. Chose a proper name for this option before user start to use it, 
'reload' or 'reload-config' or something else?
    
    > reload sounds good. Also, am open for any other suggestions
    
    4. Add test for this option.
    
    > Sure, let me see how we plug test into the codebase. Any pointers are 
appreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to