Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1262#discussion_r125064275
--- Diff:
ranger-plugin/admin-plugin/src/main/java/org/apache/hawq/ranger/service/HawqClient.java
---
@@ -74,7 +72,7 @@
private static final String DEFAULT_DATABASE = "postgres";
private static final String DEFAULT_DATABASE_TEMPLATE =
"DBTOBEREPLACEDINJDBCURL";
private static final String JDBC_DRIVER_CLASS =
"org.postgresql.Driver";
-
+ private static final String jaasApplicationName = "pgjdbc";
--- End diff --
Suggest use all capital letters for static final variable, follow the name
convention above, like XXX_XXX_XXX.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
