Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1261#discussion_r125977351
  
    --- Diff: 
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/examples/DemoTextResolver.java
 ---
    @@ -0,0 +1,55 @@
    +package org.apache.hawq.pxf.api.examples;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * 
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +import org.apache.hawq.pxf.api.OneField;
    +import org.apache.hawq.pxf.api.OneRow;
    +import org.apache.hawq.pxf.api.ReadResolver;
    +import org.apache.hawq.pxf.api.utilities.InputData;
    +import org.apache.hawq.pxf.api.utilities.Plugin;
    +
    +import java.util.LinkedList;
    +import java.util.List;
    +
    +import static org.apache.hawq.pxf.api.io.DataType.INTEGER;
    +import static org.apache.hawq.pxf.api.io.DataType.VARCHAR;
    +
    +/**
    + * Class that defines the deserializtion of one record brought from the 
external input data.
    + *
    + * Dummy implementation
    + */
    +public class DemoTextResolver extends Plugin implements ReadResolver {
    +    /**
    +     * Constructs the DemoResolver
    +     *
    +     * @param metaData
    +     */
    +    public DemoTextResolver(InputData metaData) {
    +        super(metaData);
    +    }
    +    @Override
    +    public List<OneField> getFields(OneRow row) throws Exception {
    +        List<OneField> output = new LinkedList<OneField>();
    +        Object data = row.getData();
    +        output.add(new OneField(VARCHAR.getOID(), data));
    --- End diff --
    
    Instead of adding one field we can just call inputData.getColumns() and add 
that many fields to output how many was requested. In this way, it will be 
dynamic and work with any table definition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to