Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1282#discussion_r136239626
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -271,6 +273,21 @@ int testHdfsConnect(hdfsFS * fsptr, const char * host,
int iPort,
return 0;
}
+/*
+ * check path is a trash directory
+ * path, e.g: /hawq_default/.Trash
+ */
+static int is_trash_directory(const char *path) {
--- End diff --
I suggest the name of this function uses "isTrashDirectory" instead of
current one, since the other functions name follow this style: testFooBar,
testXxxYyy, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
