Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1291#discussion_r141679468
--- Diff: pxf/pxf-service/src/main/resources/pxf-log4j.properties ---
@@ -23,7 +23,7 @@ log4j.rootLogger=INFO, ROLLINGFILE
log4j.appender.ROLLINGFILE=org.apache.log4j.RollingFileAppender
# use the same value directory as set for $PXF_LOGDIR
-log4j.appender.ROLLINGFILE.File=/var/log/pxf/pxf-service.log
+log4j.appender.ROLLINGFILE.File=$${env:$PXF_LOGDIR}/pxf-service.log
--- End diff --
Are two dollar symbols above intentional?
---