Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1301#discussion_r144450132
  
    --- Diff: pxf/build.gradle ---
    @@ -310,6 +315,7 @@ project('pxf-service') {
     
         project.distTar {
             from('src/main/resources/pxf-profiles.xml') { into 'conf' }
    +        from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
    --- End diff --
    
    @lavjain pxf-profiles.xml is better to be empty to prevent users from 
incorrectly updating the default entires in it. This is similar to the 
separation we have between pxf-private.classpath from pxf-public.classpath.
    @lavjain @sansanichfb  does that mean we don't need pxf-profiles.default ?


---

Reply via email to