Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1304#discussion_r147467878
--- Diff: pxf/Makefile ---
@@ -19,13 +19,13 @@
default: all
ifneq "$(HD)" ""
- BUILD_PARAMS= -Dhd=$(HD)
+ BUILD_PARAMS+= -Dhd=$(HD)
else
ifneq "$(PXF_HOME)" ""
- BUILD_PARAMS= -DdeployPath="$(PXF_HOME)"
+ BUILD_PARAMS+= -DdeployPath="$(PXF_HOME)"
else ifneq "$(GPHOME)" ""
PXF_HOME= "$(GPHOME)/pxf"
- BUILD_PARAMS= -DdeployPath="$(PXF_HOME)"
+ BUILD_PARAMS+= -DdeployPath="$(PXF_HOME)"
--- End diff --
minor ;) -- you can move the BUILD_PARAMS line outside of if/else since
it's the same line in both places.
---
